MSC3911 AP4: Update methods for profile updates to support attaching media #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsoyou
changed the title
4 tasks
itsoyou
force-pushed
the
syk/ap4-profile-updates
branch
from
e2f99e8 to
781bb93
Compare
itsoyou
force-pushed
the
syk/ap4-profile-updates
branch
from
781bb93 to
ed40073
Compare
jason-famedly
approved these changes
Sep 3, 2025
Contributor
jason-famedly
left a comment
jason-famedly
left a comment
There was a problem hiding this comment.
Largely, I'm ok with this. I still have the question about the idem-potency of identical avatar requests succeeding or failing, but even I do not know how to answer it
nico-famedly
reviewed
Sep 4, 2025
nico-famedly
reviewed
Sep 4, 2025
nico-famedly
reviewed
Sep 4, 2025
nico-famedly
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Media MSC3911 AP4: Update methods for profile updates to support attaching media #3354
For linking media we not only have events, but also profiles, that can be queried over federation independently of events. These should also allow attaching media.
Acceptance criteria
https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3profileuseridavatar_url should take a parameter oforg.matrix.msc3911.attach_mediato allow attaching media to a profileavatar_url, check if it's restricted and attach proper restrictionsOpen Questions
(from the ticket) We need to ensure synapse returns the right avatar over federation, otherwise this restriction is impossible to apply. That might require some digging?