MSC3911 AP4: Update methods for profile updates to support attaching media #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er illustrate that it could be responding to a request directly
…e it for 'get_local_media_info_for_request()' Now we can pull this data out without having to access the MediaRepositoryStore directly.
…or checking and setting restrictions
…e media information
…tachments as query parameters
itsoyou
changed the base branch from
msc3911
to
jason/msc3911-ap3-sending-events
…pass it throughout for persisting per event instead of after the batch
itsoyou
force-pushed
the
syk/msc3911-ap4-profile-updates
branch
from
13d8b8b to
2dc1aa2
Compare
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
from
cd18754 to
a80fe44
Compare
Member
|
You probably want to change the target branch later, but for now this makes the review easier. :) |
synapse/rest/client/profile.py
Outdated
| SynapseError: If any of the media is inappropriate or if the requester was not | ||
| allowed to attach the media | ||
| """ | ||
| if not avatar_url or avatar_url == "": |
Member
There was a problem hiding this comment.
A user is allowed to remove their avatar by setting the avatar url to "" or null.
synapse/rest/client/profile.py
Outdated
| ) | ||
|
|
||
| # Update the media restrictions to include the profile user ID | ||
| await self.hs.get_datastores().main.set_media_restrictions( |
Member
There was a problem hiding this comment.
maybe this should be done in the profile_handler?
itsoyou
force-pushed
the
syk/msc3911-ap4-profile-updates
branch
from
70c3520 to
59e78cd
Compare
jason-famedly
force-pushed
the
jason/msc3911-ap3-sending-events
branch
5 times, most recently
from
6d8d0e8 to
5529009
Compare
Member
|
@itsoyou , can you update this PR to resolve the merge conflicts and change the target branch? :) |
Contributor
Author
|
I am closing this since I created #97 with cherry-pick. too much work for rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Media MSC3911 AP4: Update methods for profile updates to support attaching media #3354
For linking media we not only have events, but also profiles, that can be queried over federation independently of events. These should also allow attaching media.
Acceptance criteria
https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3profileuseridavatar_url should take a parameter oforg.matrix.msc3911.attach_mediato allow attaching media to a profileavatar_url, check if it's restricted and attach proper restrictionsOpen Questions
(from the ticket) We need to ensure synapse returns the right avatar over federation, otherwise this restriction is impossible to apply. That might require some digging?