Famedly release v1.132.0_1 #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
… callback (#18486) This PR adds an additional `room_config` argument to the `user_may_create_room` spam checker module API callback. It will continue to work with implementations of `user_may_create_room` that do not expect the additional parameter. A side affect is that on a room upgrade the spam checker callback is called *after* doing some work to calculate the state rather than before. However, I hope that this is acceptable given the relative infrequency of room upgrades.
…size (#18457) Adds new callbacks for media related functionality: - `get_media_config_for_user` - `is_user_allowed_to_upload_media_of_size`
…408) There are alternative ways to use low numbered ports besides root. Users might be mislead into thinking they should run Synapse with root privileges.
This implements matrix-org/matrix-spec-proposals#4155, which adds support for a new account data type that blocks an invite based on some conditions in the event contents. --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
… 1 day, rather than 30 days. (#18310) Clean up `received_transactions` older than 1 day, rather than 30 days \ Reduces disk waste by homeservers Closes #6437 --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
…me Quantiles" graph (#18510) (Applies to the Grafana graphs) As discovered by @devonh, we use `synapse_storage_events_persisted_events_total` (which tracks *all* persisted events) for the "Events" rate in the "Event Send Time Quantiles" graph. This is pretty misleading as I would expect it to be the rate of events being sent given the graph title, "Event Send Time Quantiles". Since the event persistence queues are shared for local and remote events from federation and will block local events being sent, I think it does still make sense to have the event persist rate. I've updated the graph to include the rate of "Local events being persisted" and the rate of "All events being persisted". I think this properly disambiguates and clarifies what the graph is trying to show.
Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
Fixes element-hq/synapse#14240 This scratches an itch that i've had for years. We regularly run into the issue where (especially in development) appservices can go down for a period and them come back up. The ping endpoint was introduced some time ago which means Synapse can determine if an AS is up more or less immediately, so we might as well use that to schedule transaction redelivery. I believe transaction scheduling logic is largely implementation specific, so we should be in the clear to do this without any spec changes.
Fixes the self-ignore issues we've being seeing of reports of by ignoring bad requests from clients. Fixes element-hq/synapse#11963 Fix element-hq/element-web#29969 although this should also be fixed on the client to avoid confusing errors popping up while rejecting invites. Related to matrix-org/matrix-rust-sdk#5073
This small PR migrates from `unittest.assertEquals` to `unittest.assertEqual` which is deprecated from Python2.7: ```python DeprecationWarning: Please use assertEqual instead. ``` Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
…chema. (#18522) Follows: #17892, #18456 <ol> <li> Add config doc generation command to lint.sh </li> <li> Add missing `user_types` config schema </li> </ol> --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
Contributor
Author
|
There is a new Schema workflow that was added to check the configuration generation is valid and up-to-date. I have left it enabled |
Contributor
Author
|
The Complement failure at: https://github.com/famedly/synapse/actions/runs/16356268004 appears to be because of a new feature being tested that will not appear in Synapse until The sytest failure appears to be one of the known flakes from upstream. In particular this one is one of those caused by a redis failure during the replication subscribing command that prevents the worker(in this case it hit the Which manifests later as a series of(for various/all streams): I will re-run this test series to see if it goes away |
itsoyou
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of Synapse
v1.131.0_1->v1.132.0_1Upstream Changes
Special Notes:
Most interesting change here is that the configuration manual is now produced per a schema which makes it machine readable. See Machine-readable config description element-hq/synapse#17892
The linting script Synapse uses now checks this json schema file and fixes/reproduces it as necessary. Between this version and the next they did find out that it was "out-of-sync" by one line and fixed it in
v1.133.0(specifically in Fixup generated config documentation element-hq/synapse#18568). As such I will not make that fix now. The linting script is not run directly in CI but instead broken into it's component parts, and will not break in the mean time.No Famedly additions in this release