Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup VariableOrdering.append from O(N^2) to O(N) #657

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Speedup VariableOrdering.append from O(N^2) to O(N) #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Speedup VariableOrdering.append from O(N^2) to O(N)
  • Loading branch information
@ahojnnes
ahojnnes committed Aug 21, 2024
commit 0780cfe31c1f3b25edece34b37cdcb664f442090
2 changes: 1 addition & 1 deletion theseus/optimizer/variable_ordering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def __iter__(self):
return iter(self._var_order)

def append(self, var: Variable):
if var in self._var_order:
if var.name in self._var_name_to_index:
raise ValueError(
f"Variable {var.name} has already been added to the order."
)
Expand Down