More data -> tensor renaming #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mhmukadam
approved these changes
Jul 7, 2022
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
from
525bbf1
to
5fca4ac
Compare
luisenp
force-pushed
the
lep.more_data_renaming
branch
from
db92352
to
5c9afcb
Compare
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
from
5fca4ac
to
42e874a
Compare
luisenp
force-pushed
the
lep.more_data_renaming
branch
from
1c1864d
to
202fc02
Compare
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
from
42e874a
to
38f6363
Compare
luisenp
force-pushed
the
lep.more_data_renaming
branch
from
202fc02
to
b138f3a
Compare
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
* Renamed Vectorize containers and methods using data->tensor convention. * Renamed _init_data as _init_tensor for Variable subclasses. * Renamed input_data as input_tensors in Objective's forward and update methods. * Renamed _data_check as _check_tensor. * Rename normalize(data) as normalize(tensor) for Manifold classes. * Renamed variable in DLM forward for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming some additional methods and variables, mostly for consistency.