-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Variable.data
as Variable.tensor
#229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jul 7, 2022
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
from
July 7, 2022 17:46
c6b5ebe
to
525bbf1
Compare
mhmukadam
reviewed
Jul 7, 2022
mhmukadam
reviewed
Jul 7, 2022
mhmukadam
reviewed
Jul 7, 2022
mhmukadam
reviewed
Jul 7, 2022
mhmukadam
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for pushing through this painful PR. Going through it I realized how big our code has gotten now.
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
2 times, most recently
from
July 8, 2022 04:42
5fca4ac
to
42e874a
Compare
mhmukadam
reviewed
Jul 8, 2022
mhmukadam
approved these changes
Jul 8, 2022
luisenp
force-pushed
the
lep.rename_data_as_tensor
branch
from
July 12, 2022 18:09
42e874a
to
38f6363
Compare
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
* Renamed Variable.data as Variable.tensor. Passes lint and core unit tests. * Fixed embodied unit tests. * Fixed geometry unit tests. * Fixed optimizer unit tests. * Fixed remaining unit tests. * Fixed tutorials and example scripts. * Fixed some bugs from rebasing. * Fixed some lingering .data bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
refactor
Refactor library components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable.data
leads to confusion withTensor.data
, so this is much clearer.Closes #37