Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Variable.data as Variable.tensor #229

Merged
merged 8 commits into from
Jul 12, 2022
Merged

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jul 7, 2022

Variable.data leads to confusion with Tensor.data, so this is much clearer.

Closes #37

@luisenp luisenp added the refactor Refactor library components label Jul 7, 2022
@luisenp luisenp self-assigned this Jul 7, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2022
@luisenp luisenp force-pushed the lep.rename_data_as_tensor branch from c6b5ebe to 525bbf1 Compare July 7, 2022 17:46
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for pushing through this painful PR. Going through it I realized how big our code has gotten now.

@luisenp luisenp force-pushed the lep.rename_data_as_tensor branch 2 times, most recently from 5fca4ac to 42e874a Compare July 8, 2022 04:42
@luisenp luisenp merged commit 5ffb436 into main Jul 12, 2022
@luisenp luisenp deleted the lep.rename_data_as_tensor branch July 12, 2022 18:44
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
* Renamed Variable.data as Variable.tensor. Passes lint and core unit tests.

* Fixed embodied unit tests.

* Fixed geometry unit tests.

* Fixed optimizer unit tests.

* Fixed remaining unit tests.

* Fixed tutorials and example scripts.

* Fixed some bugs from rebasing.

* Fixed some lingering .data bugs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming Variable.data to some other name to avoid collisions with torch.Tensor.data
3 participants