Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify _optimize_loop method #91

Open
luisenp opened this issue Feb 21, 2022 · 0 comments
Open

Simplify _optimize_loop method #91

luisenp opened this issue Feb 21, 2022 · 0 comments
Labels
good first issue Good for newcomers refactor Refactor library components

Comments

@luisenp
Copy link
Contributor

luisenp commented Feb 21, 2022

how about

if backward_mode == BackwardMode.IMPLICIT or backward_mode == BackwardMode.TRUNCATED

so we have less redundant variables?

Originally posted by @mhmukadam in #81 (comment)
@luisenp luisenp mentioned this issue Feb 21, 2022
Merged
11 tasks
@mhmukadam mhmukadam added good first issue Good for newcomers refactor Refactor library components labels Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luisenp @mhmukadam