Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving CholmodSolveFunction and SparseStructure to separate submodule #41

Open
mhmukadam opened this issue Dec 22, 2021 · 0 comments
Open

Moving CholmodSolveFunction and SparseStructure to separate submodule #41

mhmukadam opened this issue Dec 22, 2021 · 0 comments
Labels
refactor Refactor library components

Comments

@mhmukadam
Copy link
Member

CholmodSolveFunction and SparseStructure don't depend on any of theseus' core components (including those within th.optimizer). Since they are objects of broader interest, applicable to sparse matrices outside of theseus optimization problems, we should move them to a different location. Maybe theseus.util or theseus.linalg?
@mhmukadam mhmukadam added the refactor Refactor library components label Dec 22, 2021
ddetone pushed a commit that referenced this issue Mar 29, 2022
@luisenp
Merge pull request #41 from fairinternal/lep.fix_case
4939b68 
Renamed methods named with camelCase to use lower_case_underscore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhmukadam