Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[Bugfix] - Fix attributes save #2542

Merged
merged 2 commits into from
Feb 10, 2025
Merged

--[Bugfix] - Fix attributes save #2542

merged 2 commits into from
Feb 10, 2025

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Feb 4, 2025

This PR addresses when an attributes filename has to be constructed from its handle. One of the paths to do this looked for the attributes' original file directory in its handle, and then removed that directory +1 from the handle to account for the once-missing trailing slash.

However, PR #2541 modified the fileDirectory that is stored in the attributes to include the trailing slash, which required the modifications in this PR.

This also fixes a minor attributes issue where a boolean default value is not set as an init value (i.e. so it won't be written out to json if it is not changed).

Motivation and Context

How Has This Been Tested

Locally c++ and python

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 4, 2025
@jturner65 jturner65 requested review from aclegg3 and 0mdc February 4, 2025 18:05
This was to account for missing os sep, but this os sep has now been added to fileDirectory
@jturner65 jturner65 force-pushed the Bugfix_AttrSaveNameBug branch from 59136e9 to 5d5dd1c Compare February 10, 2025 14:34
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jturner65 jturner65 merged commit dc0fac9 into main Feb 10, 2025
7 checks passed
@jturner65 jturner65 deleted the Bugfix_AttrSaveNameBug branch February 10, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants