Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[Bugfix] - Storage of attribute source directory paths #2541

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR changes how attributes' directory paths are stored so that they end in an os separator ('/'). This corrects an issue where path merging was sometimes giving erroneous results in certain conditions, and also simplifies and unifies path building code called from the scene dastaset load.

How Has This Been Tested

Locally c++ and python tests.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 February 3, 2025 18:36
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 3, 2025
@jturner65 jturner65 changed the title --[Bugfix] - Storage of directory paths --[Bugfix] - Storage of attribute source directory paths Feb 3, 2025
@jturner65 jturner65 merged commit e6f0561 into main Feb 3, 2025
7 checks passed
@jturner65 jturner65 deleted the Bugfix_SaveAssetPaths branch February 3, 2025 20:36
@jturner65 jturner65 mentioned this pull request Feb 4, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants