-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hello] Add continuous trajectory tracking & teleop #1371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
===========================================
+ Coverage 15.44% 34.41% +18.96%
===========================================
Files 349 357 +8
Lines 34777 35196 +419
===========================================
+ Hits 5372 12112 +6740
+ Misses 29405 23084 -6321
|
PierreMarza
approved these changes
Sep 15, 2022
@theophilee Can you take a look at this PR as well? |
exhaustin
added a commit
that referenced
this pull request
Sep 15, 2022
* Velocity control * Add keyboard teleop script * Debug * Hack * Debug controller * debug controller * Disable stow * Fix teleop script * Debug teleop * Wheel control test * tmp * Fix teleop once and for all * Clean up, adapt ros version * Fix * Pub to cmd_vel * Debug * debug * remove debug print * remove debug print * Clean up teleop API * Expose vel and rvel * Clean up teleop API * Initial goto controller impl * Add params * Yaw tracking modes * typing * Set tolerances * Make static methods * Add tolerances to control * Debug * Tune heading tracking * Remove acceleration and tol * Debug * Tune tol * Add turn rate limit and update tol * Tune controller * Update comments * Improve teleop * Add comment * Add docstrings and input checks * Debug docstring * Improve yaw tracking performance * Add option to pause controller * Tune teleop * Tune rate * Tune hz
exhaustin
added a commit
that referenced
this pull request
Oct 17, 2022
* Velocity control * Add keyboard teleop script * Debug * Hack * Debug controller * debug controller * Disable stow * Fix teleop script * Debug teleop * Wheel control test * tmp * Fix teleop once and for all * Clean up, adapt ros version * Fix * Pub to cmd_vel * Debug * debug * remove debug print * remove debug print * Clean up teleop API * Expose vel and rvel * Clean up teleop API * Initial goto controller impl * Add params * Yaw tracking modes * typing * Set tolerances * Make static methods * Add tolerances to control * Debug * Tune heading tracking * Remove acceleration and tol * Debug * Tune tol * Add turn rate limit and update tol * Tune controller * Update comments * Improve teleop * Add comment * Add docstrings and input checks * Debug docstring * Improve yaw tracking performance * Add option to pause controller * Tune teleop * Tune rate * Tune hz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
remote_hello_robot
andremote_hello_robot_ros
):set_velocity
set_relative_goal
,set_relative_position_goal
(remote_hello_robot_ros
only)keyboard_teleop.py
Type of change
Please check the options that are relevant.
Type of requested review
Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Please describe the tests that you ran to verify your changes and how we can reproduce.
Checklist:
tests/scripts
, (2) asv benchmarks.