Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hello] Add continuous trajectory tracking & teleop #1371

Merged
merged 48 commits into from
Sep 15, 2022

Conversation

exhaustin
Copy link
Contributor

@exhaustin exhaustin commented Sep 14, 2022

Description

Changes:

  • Within remote interfaces (remote_hello_robot and remote_hello_robot_ros):
    • Expose direct velocity control: set_velocity
    • Create continuous goto controllers: set_relative_goal, set_relative_position_goal (remote_hello_robot_ros only)
  • Add continuous teleop script keyboard_teleop.py

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.

If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.

Testing

Please describe the tests that you ran to verify your changes and how we can reproduce.

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Merging #1371 (c6f7e2c) into main (3308290) will increase coverage by 18.96%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1371       +/-   ##
===========================================
+ Coverage   15.44%   34.41%   +18.96%     
===========================================
  Files         349      357        +8     
  Lines       34777    35196      +419     
===========================================
+ Hits         5372    12112     +6740     
+ Misses      29405    23084     -6321     
Impacted Files Coverage Δ
...hitl/dashboard_app/backend/dashboard_aws_helper.py 57.57% <0.00%> (ø)
tools/hitl/utils/hitl_utils.py 21.21% <0.00%> (ø)
...itl/dashboard_app/backend/dashboard_model_utils.py 44.44% <0.00%> (ø)
tests/test_base_utils.py 98.55% <0.00%> (ø)
test_utils.py 21.87% <0.00%> (ø)
tools/hitl/utils/tests/hitl_logging_test.py 98.07% <0.00%> (ø)
...ard_app/backend/tests/dashboard_aws_helper_test.py 98.00% <0.00%> (ø)
tools/hitl/utils/hitl_logging.py 100.00% <0.00%> (ø)
dialog/post_process_logical_form.py 29.23% <0.00%> (+1.53%) ⬆️
memory/filters_conversions.py 62.19% <0.00%> (+5.20%) ⬆️
... and 126 more

@exhaustin exhaustin mentioned this pull request Sep 14, 2022
19 tasks
@exhaustin exhaustin changed the title [WIP] [Hello] Add continuous trajectory tracking & teleop [Hello] Add continuous trajectory tracking & teleop Sep 14, 2022
@exhaustin exhaustin marked this pull request as ready for review September 15, 2022 19:46
@exhaustin exhaustin merged commit 2afb324 into main Sep 15, 2022
@exhaustin exhaustin deleted the austinw/hello_traj_tracking branch September 15, 2022 20:48
@devendrachaplot
Copy link

@theophilee Can you take a look at this PR as well?

exhaustin added a commit that referenced this pull request Sep 15, 2022
* Velocity control

* Add keyboard teleop script

* Debug

* Hack

* Debug controller

* debug controller

* Disable stow

* Fix teleop script

* Debug teleop

* Wheel control test

* tmp

* Fix teleop once and for all

* Clean up, adapt ros version

* Fix

* Pub to cmd_vel

* Debug

* debug

* remove debug print

* remove debug print

* Clean up teleop API

* Expose vel and rvel

* Clean up teleop API

* Initial goto controller impl

* Add params

* Yaw tracking modes

* typing

* Set tolerances

* Make static methods

* Add tolerances to control

* Debug

* Tune heading tracking

* Remove acceleration and tol

* Debug

* Tune tol

* Add turn rate limit and update tol

* Tune controller

* Update comments

* Improve teleop

* Add comment

* Add docstrings and input checks

* Debug docstring

* Improve yaw tracking performance

* Add option to pause controller

* Tune teleop

* Tune rate

* Tune hz
exhaustin added a commit that referenced this pull request Oct 17, 2022
* Velocity control

* Add keyboard teleop script

* Debug

* Hack

* Debug controller

* debug controller

* Disable stow

* Fix teleop script

* Debug teleop

* Wheel control test

* tmp

* Fix teleop once and for all

* Clean up, adapt ros version

* Fix

* Pub to cmd_vel

* Debug

* debug

* remove debug print

* remove debug print

* Clean up teleop API

* Expose vel and rvel

* Clean up teleop API

* Initial goto controller impl

* Add params

* Yaw tracking modes

* typing

* Set tolerances

* Make static methods

* Add tolerances to control

* Debug

* Tune heading tracking

* Remove acceleration and tol

* Debug

* Tune tol

* Add turn rate limit and update tol

* Tune controller

* Update comments

* Improve teleop

* Add comment

* Add docstrings and input checks

* Debug docstring

* Improve yaw tracking performance

* Add option to pause controller

* Tune teleop

* Tune rate

* Tune hz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants