This repository was archived by the owner on Nov 3, 2023. It is now read-only.
fix frame heights in annotation task #4655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please elaborate on what the error is here? Also, I think maybe @EricMichaelSmith might be a good reviewer for this |
|
Hi @dexterju27 it looks like Pratik already fixed this in |
|
Interesting! then why does it still let me open this PR against main? Glad to know this is already fixed. |
Hmm I think if you do a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The current "frame_height": '100%', will cause the annotation task to fail. The proposed change fixed this.