This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[bugfix] Update frame_height
to integer for turn_annotations
#4625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The
frame_height
variable is set to"100%"
forturn_annotations_blueprint.py
. (UPDATE: Also found and fixed the issue for the dialcrowd task as well.)ParlAI/parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Line 220 in 38e08b0
This will cause an error at task launch time.:
botocore.exceptions.ClientError: An error occurred (ParameterValidationError) when calling the CreateHITWithHITType operation: There was an error parsing the XML question or answer data in your request. Please make sure the data is well-formed and validates against the appropriate schema. Details: cvc-elt.1.a: Cannot find the declaration of element 'ExternalQuestion'
There are two issues here.
The first is that only integer values are permitted and we are passing a string here.
The second is that per MTurk guidelines, the integer
0
should be used forFrameHeight
to designate full height.Both issues are fixed.