Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

[bugfix] Update frame_height to integer for turn_annotations #4625

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

pringshia
Copy link
Contributor

@pringshia pringshia commented Jun 21, 2022

Patch description

The frame_height variable is set to "100%" for turn_annotations_blueprint.py. (UPDATE: Also found and fixed the issue for the dialcrowd task as well.)

This will cause an error at task launch time.:

botocore.exceptions.ClientError: An error occurred (ParameterValidationError) when calling the CreateHITWithHITType operation: There was an error parsing the XML question or answer data in your request. Please make sure the data is well-formed and validates against the appropriate schema. Details: cvc-elt.1.a: Cannot find the declaration of element 'ExternalQuestion'


There are two issues here.

The first is that only integer values are permitted and we are passing a string here.

The second is that per MTurk guidelines, the integer 0 should be used for FrameHeight to designate full height.

Both issues are fixed.

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, great fix! Ha it looks like "frame_height" is set to 650 in acute_eval_blueprint and model_chat_blueprint, so if we want to be consistent maybe those should be changed too, but up to you :)

@pringshia
Copy link
Contributor Author

pringshia commented Jun 21, 2022

@EricMichaelSmith Since those are functional at the moment and won't cause a runtime crash as these would (because of the invalid format of being strings not integers), I didn't touch them here. Those could be addressed in a follow up PR perhaps, I didn't have time to test them at the moment, since they would modify the behavior of the webapp container by changing it from fixed height to fluid, full height.

@pringshia pringshia merged commit 556048d into main Jun 21, 2022
@pringshia pringshia deleted the update-frame-height branch June 21, 2022 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants