Fix CAST(interval day to second as varchar) #9386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 5, 2024
Summary: CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Differential Revision: D55796600
mbasmanova
force-pushed
the
export-D55796600
branch
from
b34a61e
to
fd78e99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
|
Thanks @mbasmanova. |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 5, 2024
Summary: CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Differential Revision: D55796600
mbasmanova
force-pushed
the
export-D55796600
branch
from
fd78e99
to
16c13b3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 5, 2024
Summary: CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Differential Revision: D55796600
mbasmanova
force-pushed
the
export-D55796600
branch
from
16c13b3
to
7ec7832
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
|
@amitkdutta Amit, thank you for review.
Fixed. Would you take another look? |
xiaoxmeng
approved these changes
Apr 5, 2024
velox/expression/ConstantExpr.cpp
Outdated
| [[fallthrough]]; | ||
| case TypeKind::BIGINT: { | ||
| if (vector.type()->isIntervalDayTime()) { | ||
| auto intervalVector = |
velox/expression/CastExpr.cpp
Outdated
| INTERVAL_DAY_TIME()->valueToString(inputFlatVector->valueAt(row)); | ||
| auto writer = exec::StringWriter<>(resultFlatVector, row); | ||
| writer.resize(output.size()); | ||
| std::memcpy(writer.data(), output.data(), output.size()); |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 5, 2024
Summary: CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Reviewed By: xiaoxmeng Differential Revision: D55796600
mbasmanova
force-pushed
the
export-D55796600
branch
from
7ec7832
to
b7334a9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
Summary: CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Reviewed By: xiaoxmeng Differential Revision: D55796600
mbasmanova
force-pushed
the
export-D55796600
branch
from
b7334a9
to
ed8a134
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55796600 |
|
This pull request has been merged in 41bed84. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9386 CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar. Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'. Fixes facebookincubator#9384 Reviewed By: xiaoxmeng Differential Revision: D55796600 fbshipit-source-id: 3d51a8eb18b434315bf9285f58b8f2cdbedca63d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
CAST expression used to handle INTERVAL DAY TO SECOND values as BIGINT. This allowed invalid casts (e.g. from varchar, to double, etc.) and produced incorrect results when casting to varchar.
Casting 1 second interval used to return '1000' instead of '0 00:00:01.000'.
Fixes #9384
Differential Revision: D55796600