Incorrect result from cast(interval day to second as varchar)

[mbasmanova]

Bug description

Velox seems to handle 'interval day to second' as an integer when casting to 'varchar'. That produces incorrect results.

For example, casting 1 day interval to varchar should return '1 00:00:00.000' but Velox returns '1'.

presto> select typeof(date('2024-01-10') - date('2024-01-9'));
         _col0
------------------------
 interval day to second

presto> select cast((date('2024-01-10') - date('2024-01-9')) as varchar);
     _col0
----------------
 1 00:00:00.000

presto> select cast((now() - date('2024-01-10')) as varchar);
      _col0
-----------------
 86 03:35:33.990

Velox repro:

TEST_F(CastExprTest, xxx) {
  // cast(interval day to second) as varchar.

  auto data = makeRowVector({
      makeFlatVector<int64_t>({1, 2, 3}, INTERVAL_DAY_TIME()),
  });

  auto result = evaluate("cast(c0 as VARCHAR)", data);
  LOG(ERROR) << result->toString();
  LOG(ERROR) << result->toString(0, 10);
}

[FLAT VARCHAR: 3 elements, no nulls]
0: 1
1: 2
2: 3

CC: @amitkdutta @kagamiori @kgpai @svm1 @aditi-pandit

System information

n/a

Relevant logs

No response

[mbasmanova]

Presto's implementation:

presto-main/src/main/java/com/facebook/presto/type/IntervalDayTimeOperators.java

    @ScalarOperator(CAST)
    @LiteralParameters("x")
    @SqlType("varchar(x)")
    public static Slice castToSlice(@SqlType(StandardTypes.INTERVAL_DAY_TO_SECOND) long value)
    {
        return utf8Slice(formatMillis(value));
    }

presto-client/src/main/java/com/facebook/presto/client/IntervalDayTime.java

    public static String formatMillis(long millis)
    {
        if (millis == Long.MIN_VALUE) {
            return LONG_MIN_VALUE;
        }
        String sign = "";
        if (millis < 0) {
            sign = "-";
            millis = -millis;
        }

        long day = millis / MILLIS_IN_DAY;
        millis %= MILLIS_IN_DAY;
        long hour = millis / MILLIS_IN_HOUR;
        millis %= MILLIS_IN_HOUR;
        long minute = millis / MILLIS_IN_MINUTE;
        millis %= MILLIS_IN_MINUTE;
        long second = millis / MILLIS_IN_SECOND;
        millis %= MILLIS_IN_SECOND;

        return format("%s%d %02d:%02d:%02d.%03d", sign, day, hour, minute, second, millis);
    }

[mbasmanova]

Velox has IntervalDayTimeType::valueToString that can be used to implement cast to varchar.