Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename VectorSerializer to IterativeVectorSerializer to distinguish it from BatchVectorSerializer #8605

Closed
wants to merge 1 commit into from
Closed

Rename VectorSerializer to IterativeVectorSerializer to distinguish it from BatchVectorSerializer #8605

wants to merge 1 commit into from

Commits on Feb 7, 2024

  1. Rename VectorSerializer to IterativeVectorSerializer to distinguish i… 

    …t from BatchVectorSerializer (facebookincubator#8605)

Summary:

To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to 
IterativeVectorSerializer.

I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in.  Once this 
diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove 
createSerializer.

Reviewed By: bikramSingh91

Differential Revision: D53201916
    @facebook-github-bot
    Kevin Wilfong authored and facebook-github-bot committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ce36c90 View commit details
    Browse the repository at this point in the history