-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename VectorSerializer to IterativeVectorSerializer to distinguish it from BatchVectorSerializer #8605
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D53201916 |
…t from BatchVectorSerializer (facebookincubator#8605) Summary: To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916
0339320
to
613c005
Compare
This pull request was exported from Phabricator. Differential Revision: D53201916 |
613c005
to
ce36c90
Compare
This pull request was exported from Phabricator. Differential Revision: D53201916 |
This pull request has been merged in 693452a. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
…t from BatchVectorSerializer (facebookincubator#8605) Summary: Pull Request resolved: facebookincubator#8605 To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer. I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer. Reviewed By: bikramSingh91 Differential Revision: D53201916 fbshipit-source-id: 69947b4bf7a50f43fd27126b3b29688e9d8300ef
Summary:
To make the differences between VectorSerializer and BatchVectorSerializer more explicit, I'm renaming VectorSerializer to IterativeVectorSerializer.
I also rename createSerializer to createIterativeSerializer, however, since Presto uses createSerializer, I've left it in. Once this diff lands, I'll land a change in Presto to use createIterativeSerializer, and then land a change back in Velox to remove createSerializer.
Differential Revision: D53201916