Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add row size estimation support for selective ARRAY and MAP column readers #10622

Closed
wants to merge 1 commit into from
Closed

Add row size estimation support for selective ARRAY and MAP column readers #10622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions velox/dwio/common/SelectiveColumnReader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,11 +477,15 @@ class SelectiveColumnReader {
template <typename T>
void filterNulls(RowSet rows, bool isNull, bool extractValues);

// Temporary method for estimate in-memory row size (number of bits) of this
// column for Nimble. Will be removed once column statistics are added for
// Nimble.
virtual std::optional<size_t> estimatedRowBitSize() const {
return std::nullopt;
// Temporary method for estimate total in-memory byte size and row count of
// current encoding chunk on this column for Nimble. Will be removed once
// column statistics are added for Nimble. Note that the estimations are
// based on current encoding chunk, so in multi-chunk stripe this is not
// accurate. Other formats should not use this.
virtual bool estimateMaterializedSize(
size_t& /*byteSize*/,
size_t& /*rowCount*/) const {
return false;
}

StringView copyStringValueIfNeed(folly::StringPiece value) {
Expand Down
Loading