Add row size estimation support for selective ARRAY and MAP column readers #10622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D60477335 |
|
This pull request was exported from Phabricator. Differential Revision: D60477335 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Aug 6, 2024
…aders (facebookincubator#10622) Summary: Pull Request resolved: facebookincubator#10622 To do estimation on repeated types, we need the method to return not just the byte size but also the row count of inner data, so that we can get estimation on the average size of elements in one array or map. Reviewed By: HuamengJiang Differential Revision: D60477335
…aders (facebookincubator#10622) Summary: Pull Request resolved: facebookincubator#10622 To do estimation on repeated types, we need the method to return not just the byte size but also the row count of inner data, so that we can get estimation on the average size of elements in one array or map. Reviewed By: HuamengJiang Differential Revision: D60477335
|
This pull request was exported from Phabricator. Differential Revision: D60477335 |
HuamengJiang
approved these changes
Aug 7, 2024
|
This pull request has been merged in 58a80e5. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To do estimation on repeated types, we need the method to return not
just the byte size but also the row count of inner data, so that we can get
estimation on the average size of elements in one array or map.
Differential Revision: D60477335