methods.py internal/external check 4/n - Rename SwissCheesePlattScaling -> PlattScalingWithFeatures #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
flinder
force-pushed
the
export-D88475946
branch
from
3c84e65 to
35adef7
Compare
… internal only module (#36) Summary: Pull Request resolved: facebookincubator/MCGrad#36 * MCNet is not part of the OSS release * Create a new module for internal only implementations * For backward compatibility re-export MCNet in `methods.py` with `oss-disable` directive * To avoid circular import due to `BaseCalibrator` move the abstract class to a new private module Differential Revision: D88473570 Reviewed By: TaXxER
…tebook Summary: as title Differential Revision: D88475947
…ng -> PlattScalingWithFeatures (#34) Summary: Pull Request resolved: facebookincubator/MCGrad#34 SwissCheese is not a public name so we should rename this to something more generic. * Rename the implementation `SwissCheesePlattScaling` -> `PlattScalingWithFeatures` * Create a wrapper class of `SwissCheesePlattScaling` for backward compatibility (oss-disabled) Reviewed By: TaXxER Differential Revision: D88475946 Privacy Context Container: L1334583
flinder
force-pushed
the
export-D88475946
branch
from
35adef7 to
a71e07e
Compare
|
This pull request has been merged in 1dd33c3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SwissCheese is not a public name so we should rename this to something more generic.
SwissCheesePlattScaling->PlattScalingWithFeaturesSwissCheesePlattScalingfor backward compatibility (oss-disabled)Differential Revision:
D88475946
Privacy Context Container: L1334583