methods.py internal/external check 1/n - Move MCNet implementation to internal only module #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
flinder
force-pushed
the
export-D88473570
branch
4 times, most recently
from
3e6bbe4 to
b17e14b
Compare
… internal only module (#36) Summary: Pull Request resolved: facebookincubator/MCGrad#36 * MCNet is not part of the OSS release * Create a new module for internal only implementations * For backward compatibility re-export MCNet in `methods.py` with `oss-disable` directive * To avoid circular import due to `BaseCalibrator` move the abstract class to a new private module Reviewed By: TaXxER Differential Revision: D88473570
flinder
force-pushed
the
export-D88473570
branch
from
b17e14b to
3bcd326
Compare
|
This pull request has been merged in 991e8d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
methods.pywithoss-disabledirectiveBaseCalibratormove the abstract class to a new private moduleDifferential Revision: D88473570