Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Change the Facebook SDK to version 9 #833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Change the Facebook SDK to version 9 #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51a2873
Update react-native-fbsdk.podspec
jzhan-canva Feb 4, 2021
338b02b
Update build.gradle
jzhan-canva Feb 4, 2021
6b35c30
Update build.gradle
jzhan-canva Feb 4, 2021
062b029
add mavenCentral() to build.gradle
Feb 4, 2021
671158c
update example app
Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ repositories {
jcenter()
}

def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '[7.1.0, 9)')
def FACEBOOK_SDK_VERSION = safeExtGet('facebookSdkVersion', '9.0.+')

dependencies {
//noinspection GradleDynamicVersion
Expand Down
1 change: 1 addition & 0 deletions example/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ allprojects {
google()
jcenter()
maven { url 'https://www.jitpack.io' }
mavenCentral()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like to know why is this needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I put mavenCentral in the package's build.gradle, it won't find the facebook-android-sdk:9. I had to put it in rout project level

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for the explanation.

Just take a look to the README.md, this might be missing for a long time.

}
}
40 changes: 20 additions & 20 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,20 @@ PODS:
- React-Core (= 0.63.3)
- React-jsi (= 0.63.3)
- ReactCommon/turbomodule/core (= 0.63.3)
- FBSDKCoreKit (8.2.0):
- FBSDKCoreKit/Basics (= 8.2.0)
- FBSDKCoreKit/Core (= 8.2.0)
- FBSDKCoreKit/Basics (8.2.0)
- FBSDKCoreKit/Core (8.2.0):
- FBSDKCoreKit (9.0.0):
- FBSDKCoreKit/Basics (= 9.0.0)
- FBSDKCoreKit/Core (= 9.0.0)
- FBSDKCoreKit/Basics (9.0.0)
- FBSDKCoreKit/Core (9.0.0):
- FBSDKCoreKit/Basics
- FBSDKLoginKit (8.2.0):
- FBSDKLoginKit/Login (= 8.2.0)
- FBSDKLoginKit/Login (8.2.0):
- FBSDKCoreKit (~> 8.2.0)
- FBSDKShareKit (8.2.0):
- FBSDKShareKit/Share (= 8.2.0)
- FBSDKShareKit/Share (8.2.0):
- FBSDKCoreKit (~> 8.2.0)
- FBSDKLoginKit (9.0.0):
- FBSDKLoginKit/Login (= 9.0.0)
- FBSDKLoginKit/Login (9.0.0):
- FBSDKCoreKit (~> 9.0.0)
- FBSDKShareKit (9.0.0):
- FBSDKShareKit/Share (= 9.0.0)
- FBSDKShareKit/Share (9.0.0):
- FBSDKCoreKit (~> 9.0.0)
- Folly (2020.01.13.00):
- boost-for-react-native
- DoubleConversion
Expand Down Expand Up @@ -205,13 +205,13 @@ PODS:
- react-native-fbsdk/Login (= 3.0.0)
- react-native-fbsdk/Share (= 3.0.0)
- react-native-fbsdk/Core (3.0.0):
- FBSDKCoreKit (~> 8.1)
- FBSDKCoreKit (~> 9.0)
- React
- react-native-fbsdk/Login (3.0.0):
- FBSDKLoginKit (~> 8.1)
- FBSDKLoginKit (~> 9.0)
- React
- react-native-fbsdk/Share (3.0.0):
- FBSDKShareKit (~> 8.1)
- FBSDKShareKit (~> 9.0)
- React
- React-RCTActionSheet (0.63.3):
- React-Core/RCTActionSheetHeaders (= 0.63.3)
Expand Down Expand Up @@ -374,9 +374,9 @@ SPEC CHECKSUMS:
DoubleConversion: cde416483dac037923206447da6e1454df403714
FBLazyVector: 878b59e31113e289e275165efbe4b54fa614d43d
FBReactNativeSpec: 7da9338acfb98d4ef9e5536805a0704572d33c2f
FBSDKCoreKit: 4afd6ff53d8133a433dbcda44451c9498f8c6ce4
FBSDKLoginKit: 7181765f2524d7ebf82d9629066c8e6caafc99d0
FBSDKShareKit: 0c0d51b3af47075a85ed9bea0e28b2fc70e3594b
FBSDKCoreKit: ac6cc500b8e104bb9a4dd20b1527b5d199123c2e
FBSDKLoginKit: e9b6542fdee322333502ab497f628b011dce7d78
FBSDKShareKit: e9a5d805d0831489a09dd14fa6fc8ba20d6355f3
Folly: b73c3869541e86821df3c387eb0af5f65addfab4
glog: 40a13f7840415b9a77023fbcae0f1e6f43192af3
RCTRequired: 48884c74035a0b5b76dbb7a998bd93bcfc5f2047
Expand All @@ -389,7 +389,7 @@ SPEC CHECKSUMS:
React-jsi: df07aa95b39c5be3e41199921509bfa929ed2b9d
React-jsiexecutor: b56c03e61c0dd5f5801255f2160a815f4a53d451
React-jsinspector: 8e68ffbfe23880d3ee9bafa8be2777f60b25cbe2
react-native-fbsdk: 8e92c7a334fd8d9c2b5d8b8fcd7ae2c314161099
react-native-fbsdk: 63d0974790749fab91727b21799af4acd37cf04f
React-RCTActionSheet: 53ea72699698b0b47a6421cb1c8b4ab215a774aa
React-RCTAnimation: 1befece0b5183c22ae01b966f5583f42e69a83c2
React-RCTBlob: 0b284339cbe4b15705a05e2313a51c6d8b51fa40
Expand Down
6 changes: 3 additions & 3 deletions react-native-fbsdk.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ Pod::Spec.new do |s|
s.dependency 'React'

s.subspec 'Core' do |ss|
ss.dependency 'FBSDKCoreKit', '~> 8.1'
ss.dependency 'FBSDKCoreKit', '~> 9.0'
ss.source_files = 'ios/RCTFBSDK/core/*.{h,m}'
end

s.subspec 'Login' do |ss|
ss.dependency 'FBSDKLoginKit', '~> 8.1'
ss.dependency 'FBSDKLoginKit', '~> 9.0'
ss.source_files = 'ios/RCTFBSDK/login/*.{h,m}'
end

s.subspec 'Share' do |ss|
ss.dependency 'FBSDKShareKit', '~> 8.1'
ss.dependency 'FBSDKShareKit', '~> 9.0'
ss.source_files = 'ios/RCTFBSDK/share/*.{h,m}'
end
end