Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Change the Facebook SDK to version 9 #833

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jzhan-canva
Copy link

Change the Facebook SDK to version 9. Given there is no breaking changes, all API should work as previous.

Fixes #832

@facebook-github-bot
Copy link

Hi @zhantx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@@ -33,5 +33,6 @@ allprojects {
google()
jcenter()
maven { url 'https://www.jitpack.io' }
mavenCentral()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like to know why is this needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I put mavenCentral in the package's build.gradle, it won't find the facebook-android-sdk:9. I had to put it in rout project level

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tanks for the explanation.

Just take a look to the README.md, this might be missing for a long time.

@Fl0p
Copy link

Fl0p commented Feb 8, 2021

+1

@Fl0p
Copy link

Fl0p commented Feb 8, 2021

@jzhan-canva
Copy link
Author

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@therealchiko
Copy link

thanks for all the incredible work with regards to fb sdk 9.0 @zhantx. Does anyone know when this will get merged and the next release published?

@Fl0p
Copy link

Fl0p commented Feb 19, 2021

Waiting for merge...

@rnike
Copy link
Contributor

rnike commented Feb 20, 2021

Please take a full review of the conversations in #832, it seems like it will never be merged because Facebook is not going to maintain this package anymore.

For anyone who is waiting for this to be merged, I would recommend just fork or use patch-package.

Or you can just add it from our forked repo, our repo include commits from this PR. (Thanks @zhantx)

To install:
yarn add VeryBuy/react-native-fbsdk#release/3.0.1

There are also two changes we have done:

@criss93
Copy link

criss93 commented Feb 24, 2021

@janicduplessis can you review this? We need the SDK upgrade on this package, please!

thebergamo pushed a commit to thebergamo/react-native-fbsdk-next that referenced this pull request Mar 9, 2021
@Kamal-Walia
Copy link

Please let us know when this is going to merge in the package?
Till the time I've forked this package and included this PR.
https://github.com/Kamal-Walia/react-native-fbsdk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plan on upgrading to FB SDK v9 for iOS?
7 participants