This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Selection API to ASTableNode and ASCollectionNode #2450
Comments
george-gw
added a commit
to george-gw/AsyncDisplayKit
that referenced
this issue
Oct 21, 2016
Adlai-Holler
pushed a commit
that referenced
this issue
Oct 24, 2016
* Added selection API to ASTableNode and ASCollectionNode (#2450) * Updated test case to use collectionNode instead of collectionView for the selection tests. * Fixed typos. Added asserts for main thread. Updated ASCollectionViewTests for multiple selections for nodes. * Added assigns to the different properties.
@george-gw Landed a diff to add this API. I'm open to discussion, but I'm toying with the idea of deprecating the view versions of these methods. The view versions should take view index paths, but users should never be dealing with view index paths and they're much more likely to not understand that distinction, and to call |
The continuation work will be done in #2485. Thanks @george-gw ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add
selectRow/ItemAtIndexPath:
anddeselectRow/ItemAtIndexPath:
Since the view versions of these methods currently accept node index paths (for backwards compatibility purposes) these methods can just call through to the view for now.
The text was updated successfully, but these errors were encountered: