Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Add Selection API to ASTableNode and ASCollectionNode #2450

Closed
Adlai-Holler opened this issue Oct 21, 2016 · 2 comments
Closed

Add Selection API to ASTableNode and ASCollectionNode #2450

Adlai-Holler opened this issue Oct 21, 2016 · 2 comments

Comments

@Adlai-Holler
Copy link
Contributor

Add selectRow/ItemAtIndexPath: and deselectRow/ItemAtIndexPath:

Since the view versions of these methods currently accept node index paths (for backwards compatibility purposes) these methods can just call through to the view for now.

george-gw added a commit to george-gw/AsyncDisplayKit that referenced this issue Oct 21, 2016
Adlai-Holler pushed a commit that referenced this issue Oct 24, 2016
* Added selection API to ASTableNode and ASCollectionNode (#2450)

* Updated test case to use collectionNode instead of collectionView for the selection tests.

* Fixed typos.
Added asserts for main thread.
Updated ASCollectionViewTests for multiple selections for nodes.

* Added assigns to the different properties.
@Adlai-Holler
Copy link
Contributor Author

@george-gw Landed a diff to add this API.

I'm open to discussion, but I'm toying with the idea of deprecating the view versions of these methods. The view versions should take view index paths, but users should never be dealing with view index paths and they're much more likely to not understand that distinction, and to call tableView selectRowAtIndexPath: and not know why it doesn't work as expected. cc @maicki @levi @appleguy @garrettmoon

@Adlai-Holler
Copy link
Contributor Author

The continuation work will be done in #2485. Thanks @george-gw !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant