Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Deprecate indexPath-based Methods on ASTableView/ASCollectionView #2485

Closed
2 tasks
Adlai-Holler opened this issue Oct 26, 2016 · 2 comments
Closed
2 tasks

Comments

@Adlai-Holler
Copy link
Contributor

We can't prevent UIKit from calling these methods on self but users should virtually never call methods like these on ASTableView/ASCollectionView, and we shouldn't override them.

-selectRowAtIndexPath:animated:
-scrollToRowAtIndexPath:animated:
-rectForRowAtIndexPath:  // !! Needs to be added to ASTableNode
-cellForRowAtIndexPath:  // !! Needs to be added to ASTableNode
-indexPathForSelectedRow // !! Needs to be added to ASTableNode
-indexPathForRowAtPoint:  // !! Needs to be added to ASTableNode
-indexPathsForRowsInRect:  // !! Needs to be added to ASTableNode
-indexPathsForVisibleRows:  // !! Needs to be added to ASTableNode

It will be a bummer for developers, but the index paths just won't line up – it's part of the asynchronous nature of table node and collection node. @george-gw Would you be willing to implement the methods above, using convertIndexPathFromTableNode:?

  • Implement replacement methods
  • Deprecate original methods

Thoughts @appleguy @maicki @garrettmoon ?

@george-gw
Copy link
Contributor

@Adlai-Holler will do

@Adlai-Holler
Copy link
Contributor Author

Resolved via #2498

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants