C++ style enums 7/N: MeasureMode #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Differential Revision: D49271165 fbshipit-source-id: 8f5c29fbc4641f76f18f7a90015afc0eb0558b01
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Differential Revision: D49271165 fbshipit-source-id: 2ea493123db9a9ca1e47454a39ba6838bbff98e8
NickGerleman
force-pushed
the
export-D49271165
branch
from
74d5350
to
66b2e12
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Differential Revision: D49271165 fbshipit-source-id: 84b79aed61cc34f91292911e0be2663c3cf481cc
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 458562c5944e3574cd86fbbc9c5890076ddce7da
NickGerleman
force-pushed
the
export-D49271165
branch
from
66b2e12
to
8d770b9
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: a9646ed7d625471064953e44ad3fe18725dfac84
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: 0ba9a79e19616f55abdc15012fbfd26933c6d179
Differential Revision: D49269117 fbshipit-source-id: 0a1dd2c4359c4871b01b21e61d636fbc7f239f2a
Differential Revision: D49269440 fbshipit-source-id: 17582f27ed995f861deeed6bcb0c0a00d12da47e
Summary: This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 70e61b04543a2431766dfe1e51b0731e8e753188
Summary: This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 13ce04476546b69f222e38885f12597e0e8cdae9
Summary: This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 10c8dd6e711581a62f234658016afe697e2e44ce
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: a6ab7509a3f74bc6e1c42c0ce3376e1e7447f4dd
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
force-pushed
the
export-D49271165
branch
from
8d770b9
to
22bee6e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 03000f9c22096799ca1a61c1f9c168ce0933c34d
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 273c9ed0a61c3965e469548d29d37e4566c974dc
|
This pull request has been merged in ed406f0. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 273c9ed0a61c3965e469548d29d37e4566c974dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGMeasureMode to MeasureMode
Differential Revision: D49271165