C++ style enums 7/N: MeasureMode #39452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Differential Revision: D49271165 fbshipit-source-id: 2ea493123db9a9ca1e47454a39ba6838bbff98e8
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Differential Revision: D49271165 fbshipit-source-id: 84b79aed61cc34f91292911e0be2663c3cf481cc
NickGerleman
force-pushed
the
export-D49271165
branch
from
a24bbda
to
00b48e0
Compare
Base commit: 598b7ed |
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 458562c5944e3574cd86fbbc9c5890076ddce7da
NickGerleman
force-pushed
the
export-D49271165
branch
from
00b48e0
to
e316152
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: a9646ed7d625471064953e44ad3fe18725dfac84
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: bfde22f7361c9160b9c475fa458b3dc89c9fab19
Differential Revision: D49269117 fbshipit-source-id: 43d4aaad8ee30a8150f0edc9f8a445e2b2e6f40a
Differential Revision: D49269440 fbshipit-source-id: 628a91fda1db878a531df47359f08deb0cc65e00
Summary: This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 6749b71a3f3c32e34d58265097962153b50e87f6
Summary: This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 2c9d3dbd2002af1a48fce704a5ab0be4147293b7
Summary: This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 532996d68188ee7709b1a72fbde34a5816de0d16
Summary: Pull Request resolved: facebook#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 03000f9c22096799ca1a61c1f9c168ce0933c34d
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: facebook#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: a6ab7509a3f74bc6e1c42c0ce3376e1e7447f4dd
|
This pull request was exported from Phabricator. Differential Revision: D49271165 |
NickGerleman
force-pushed
the
export-D49271165
branch
from
e316152
to
cf38313
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 Pull Request resolved: #1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 273c9ed0a61c3965e469548d29d37e4566c974dc
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39452 X-link: facebook/yoga#1389 This converts usages of YGMeasureMode to MeasureMode Reviewed By: rozele Differential Revision: D49271165 fbshipit-source-id: 273c9ed0a61c3965e469548d29d37e4566c974dc
|
This pull request has been merged in 3b27c39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1389
This converts usages of YGMeasureMode to MeasureMode
Differential Revision: D49271165