C++ style enums 6/N: PrintOptions #1385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: f7cd1e123d7c1628cc98661ea0b2587b5500de48
NickGerleman
force-pushed
the
export-D49270929
branch
from
928f4ef
to
16dd4e1
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 9385350dc71cdf4a354b9691897262910e133878
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 0177c8554e8329500b91c3a74f19644ded6a7354
NickGerleman
force-pushed
the
export-D49270929
branch
from
16dd4e1
to
ebbe177
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 8b4c55a822bd1e412c7d670da45684eea3afd810
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: 837a2f5eccea0fde973616de8cd651afd0e15a59
NickGerleman
force-pushed
the
export-D49270929
branch
from
ebbe177
to
47cd849
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ea01bfa3b46b3868ac1c8d74d707f4453ffa420b
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: c737fd0a8058cb0188fdb873f587ba8f1b6edf1f
Differential Revision: D49269117 fbshipit-source-id: 599dec9140de399035e6c886ee46c72128203cba
Differential Revision: D49269440 fbshipit-source-id: c3edc53676f9fe3023c0badfe71385a6c3a9f1aa
Summary: This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 476230d859186f63c315529cd58e755981c5db12
Summary: This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 164530d0979ca5319d51b76c4b4b7bae538837de
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: 96afa28263f81a9cc6fe1ad5f2ab133198eb8eef
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
force-pushed
the
export-D49270929
branch
from
47cd849
to
cf8ccbd
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: d743ad8c0019fb723db19488e7c6823eb3864466
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ad98dd25865138808d25b48eff22fbe81ccdd352
|
This pull request has been merged in 383b325. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ad98dd25865138808d25b48eff22fbe81ccdd352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGPrintOptions to PrintOptions
Differential Revision: D49270929