C++ style enums 6/N: PrintOptions #39449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: f7cd1e123d7c1628cc98661ea0b2587b5500de48
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 9385350dc71cdf4a354b9691897262910e133878
NickGerleman
force-pushed
the
export-D49270929
branch
from
38ed5b1
to
ca1a960
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 0177c8554e8329500b91c3a74f19644ded6a7354
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Differential Revision: D49270929 fbshipit-source-id: 8b4c55a822bd1e412c7d670da45684eea3afd810
NickGerleman
force-pushed
the
export-D49270929
branch
from
ca1a960
to
63f4949
Compare
Base commit: 598b7ed |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: 837a2f5eccea0fde973616de8cd651afd0e15a59
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ea01bfa3b46b3868ac1c8d74d707f4453ffa420b
NickGerleman
force-pushed
the
export-D49270929
branch
from
63f4949
to
b0e73a9
Compare
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: 12910d52132e59a653e06e7671e509d3d81ca797
Differential Revision: D49269117 fbshipit-source-id: da0f8eb39e4a9cbc85bdfb192c4575dda6a4fab4
Differential Revision: D49269440 fbshipit-source-id: fbfe8292764b659ccec362be0e311fa6db8b8ed2
Summary: This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 3e6fdbd7e571b079a00a22c0c31db2654bbc4cca
Summary: This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 5295e49dd1495691778e46329139ee8c7f978c0b
Summary: Pull Request resolved: facebook#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: d743ad8c0019fb723db19488e7c6823eb3864466
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: facebook#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: 96afa28263f81a9cc6fe1ad5f2ab133198eb8eef
|
This pull request was exported from Phabricator. Differential Revision: D49270929 |
NickGerleman
force-pushed
the
export-D49270929
branch
from
b0e73a9
to
8d1e892
Compare
|
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 Pull Request resolved: #1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ad98dd25865138808d25b48eff22fbe81ccdd352
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39449 X-link: facebook/yoga#1385 This converts usages of YGPrintOptions to PrintOptions Reviewed By: rozele Differential Revision: D49270929 fbshipit-source-id: ad98dd25865138808d25b48eff22fbe81ccdd352
|
This pull request has been merged in 094046c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGPrintOptions to PrintOptions
Differential Revision: D49270929