C++ style enums 2/N: NodeType #1383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#1383 Differential Revision: D49269117 fbshipit-source-id: b886269a8bfb847cb8b4e39e378e5fa732b317b7
NickGerleman
force-pushed
the
export-D49269117
branch
from
2af988a
to
434bd2d
Compare
NickGerleman
commented
Sep 14, 2023
NickGerleman
commented
Sep 14, 2023
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: a2c2f98305d69ff494f1de7821734b1e36d89667
NickGerleman
force-pushed
the
export-D49269117
branch
from
97999ec
to
9a21236
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: b886a2f4e1e31c0d3b926a27472949cf74c6b502
NickGerleman
force-pushed
the
export-D49269117
branch
from
9a21236
to
9338316
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 4e351bcb96790b501c8dda218943a5124af6c99c
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 80754a402d96b51ec8f95c87aee856af9f828de6
NickGerleman
force-pushed
the
export-D49269117
branch
from
9338316
to
8431d00
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 5e302f093c07e335abf49e64669bb8994c7b6c55
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 3b20f822be89c9cfcbc86292a19c0ed18cd97e2d
NickGerleman
force-pushed
the
export-D49269117
branch
from
8431d00
to
b29ee8a
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 7c628e3a70246115dbf7b3330c916015b7880ca7
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: f3f4f71d7e40a224d6b53a68a0251b05dc76da19
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 55c71143f9dca14bc92ceec5c9acc68f70cb108c
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
force-pushed
the
export-D49269117
branch
from
b29ee8a
to
48f28a2
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 5516e491e82f90c9765b1548da118d8c97ef8609
|
This pull request has been merged in 9129a0a. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 27318279fe555c28c605625a160d5be781b662b8
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 27318279fe555c28c605625a160d5be781b662b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D49269117