C++ style enums 2/N: NodeType #39450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 80754a402d96b51ec8f95c87aee856af9f828de6
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 5e302f093c07e335abf49e64669bb8994c7b6c55
NickGerleman
force-pushed
the
export-D49269117
branch
from
dd7b1d2
to
e26b0b2
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 3b20f822be89c9cfcbc86292a19c0ed18cd97e2d
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Differential Revision: D49269117 fbshipit-source-id: 7c628e3a70246115dbf7b3330c916015b7880ca7
NickGerleman
force-pushed
the
export-D49269117
branch
from
e26b0b2
to
76a8a98
Compare
Base commit: 598b7ed |
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: f81090126872a97d06d07bfd9aa11dcf0b9b3d51
Summary: Pull Request resolved: facebook#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 5516e491e82f90c9765b1548da118d8c97ef8609
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: facebook#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 55c71143f9dca14bc92ceec5c9acc68f70cb108c
|
This pull request was exported from Phabricator. Differential Revision: D49269117 |
NickGerleman
force-pushed
the
export-D49269117
branch
from
76a8a98
to
900aa69
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39450 Pull Request resolved: #1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 27318279fe555c28c605625a160d5be781b662b8
|
This pull request has been merged in 850c93a. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39450 X-link: facebook/yoga#1383 This converts usages of YGNodeType to NodeType Reviewed By: rozele Differential Revision: D49269117 fbshipit-source-id: 27318279fe555c28c605625a160d5be781b662b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/yoga#1383
This converts usages of YGNodeType to NodeType
Differential Revision: D49269117