Ship the fix for local reference overflow in Yoga #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
pushed a commit
to pentiumao/yoga
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: d212d8e543f9129cb20a81ad03b5dea4dc5976c0
pentiumao
force-pushed
the
export-D48607502
branch
from
e9589a0
to
287e70d
Compare
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 6ef7f9caf3e6b905bc561264f0ecb5ac17335482
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 00ecedf7a53ad9c28c8dbd24f6fd1811657815e6
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 2bb5b96d3c2209c9c63867ecc2cbb0cdbff42cc6
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
pushed a commit
to pentiumao/yoga
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 2c8867d21f7f96e0bd653aa74cbeb3709fa9383e
pentiumao
force-pushed
the
export-D48607502
branch
from
287e70d
to
66f2289
Compare
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 7182fb23480029c4b6521811c8f429097e5ac935
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
pushed a commit
to pentiumao/yoga
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 13f0bdc9a2c73484b9cf9d525c94ec2573bff3d7
pentiumao
force-pushed
the
export-D48607502
branch
from
66f2289
to
6ea31e6
Compare
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 83601ba7c1f347ac0c2e141e1d59d1f6f01a1329
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 8c6c3975b333ccd1d300aa33903fc1353cf61701
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
pushed a commit
to pentiumao/yoga
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: f28a1e6b6033e854cfa0adb54f9f3c5c84b1b62c
pentiumao
force-pushed
the
export-D48607502
branch
from
6ea31e6
to
3fb7ddd
Compare
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 9d28af88c0083fef6524bce2390991c0636c770b
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: cd9a1b888c272dc47c3db8b68eba0631fe9d556f
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 61762766833e4e83fff9dfe82d06a8b046919090
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
pushed a commit
to pentiumao/yoga
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 605f63125d781e1bb416bac0195b6a600841ea71
pentiumao
force-pushed
the
export-D48607502
branch
from
3fb7ddd
to
11fd628
Compare
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 1665eb34af0bfeba26a68c420be4cc02f0bda6f2
Summary: X-link: facebook/litho#954 X-link: facebook/react-native#39132 Pull Request resolved: facebook#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 64a8425d83e322a62af33e0511fcce7475785bbf
|
This pull request was exported from Phabricator. Differential Revision: D48607502 |
pentiumao
force-pushed
the
export-D48607502
branch
from
11fd628
to
14c0f96
Compare
pentiumao
pushed a commit
to pentiumao/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 02e64193cf5dc92ebdf7cf0aea6498db35454171
pentiumao
pushed a commit
to pentiumao/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 77f25d83b8778a375b7124c5b72a3e0efe1e00e2
|
This pull request has been merged in 49fbd40. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: #954 X-link: facebook/react-native#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 79552bc76879d1fc15341423ae6fbadeab2fb7af
jpdriver
pushed a commit
to jpdriver/react-native
that referenced
this pull request
Aug 24, 2023
Summary: X-link: facebook/litho#954 Pull Request resolved: facebook#39132 X-link: facebook/yoga#1347 # Context Reviewed By: NickGerleman, astreet Differential Revision: D48607502 fbshipit-source-id: 79552bc76879d1fc15341423ae6fbadeab2fb7af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: # Context
Differential Revision: D48607502