Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship the fix for local reference overflow in Yoga #39132

Closed
wants to merge 1 commit into from

Conversation

pentiumao
Copy link

Summary: # Context

Differential Revision: D48607502

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

@analysis-bot
Copy link

analysis-bot commented Aug 23, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,963,940 -1,942
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,298 -46
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d5b656c
Branch: main

pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: d212d8e543f9129cb20a81ad03b5dea4dc5976c0
pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 6ef7f9caf3e6b905bc561264f0ecb5ac17335482
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 00ecedf7a53ad9c28c8dbd24f6fd1811657815e6
pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 2bb5b96d3c2209c9c63867ecc2cbb0cdbff42cc6
pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 2c8867d21f7f96e0bd653aa74cbeb3709fa9383e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 7182fb23480029c4b6521811c8f429097e5ac935
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 13f0bdc9a2c73484b9cf9d525c94ec2573bff3d7
pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 83601ba7c1f347ac0c2e141e1d59d1f6f01a1329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 8c6c3975b333ccd1d300aa33903fc1353cf61701
pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: f28a1e6b6033e854cfa0adb54f9f3c5c84b1b62c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 9d28af88c0083fef6524bce2390991c0636c770b
pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: cd9a1b888c272dc47c3db8b68eba0631fe9d556f
pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 61762766833e4e83fff9dfe82d06a8b046919090
pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 605f63125d781e1bb416bac0195b6a600841ea71
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 1665eb34af0bfeba26a68c420be4cc02f0bda6f2
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 77f25d83b8778a375b7124c5b72a3e0efe1e00e2
pentiumao pushed a commit to pentiumao/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: facebook#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 64a8425d83e322a62af33e0511fcce7475785bbf
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48607502

pentiumao pushed a commit to pentiumao/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 02e64193cf5dc92ebdf7cf0aea6498db35454171
facebook-github-bot pushed a commit to facebook/yoga that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

X-link: facebook/react-native#39132

Pull Request resolved: #1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 79552bc76879d1fc15341423ae6fbadeab2fb7af
facebook-github-bot pushed a commit to facebook/litho that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: #954

X-link: facebook/react-native#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 79552bc76879d1fc15341423ae6fbadeab2fb7af
@github-actions
Copy link

This pull request was successfully merged by Andrew Wang in 10a076f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 24, 2023
jpdriver pushed a commit to jpdriver/react-native that referenced this pull request Aug 24, 2023
Summary:
X-link: facebook/litho#954

Pull Request resolved: facebook#39132

X-link: facebook/yoga#1347

# Context

Reviewed By: NickGerleman, astreet

Differential Revision: D48607502

fbshipit-source-id: 79552bc76879d1fc15341423ae6fbadeab2fb7af
@javache javache closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants