Add test case for multi-project schema panic#5135
Open
captbaritone wants to merge 2 commits intofacebook:mainfrom
Open
Add test case for multi-project schema panic#5135captbaritone wants to merge 2 commits intofacebook:mainfrom
captbaritone wants to merge 2 commits intofacebook:mainfrom
Conversation
988d784 to
e9c9aa8
Compare
captbaritone
commented
Jan 12, 2026
| @@ -0,0 +1,2 @@ | |||
| @nocommit | |||
| Run snapshot tests with UPDATE_SNAPSHOTS=1 to update this new file. | |||
Contributor
Author
There was a problem hiding this comment.
Can't be generated because compiler/test panics
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D90526264. |
Differential Revision: D87093423
Summary: - Adds integration test `schema_not_in_project_sources` that reproduces a panic when using multi-project config ## The Issue When using a relay config with multiple projects where the schema file is located outside of all project source directories, the compiler panics at `build_schema.rs:115` with "no entry found for key". ## Reproduction https://github.com/budde377/relay-multirepo-reproduction ## Test plan ``` cargo test --test relay_compiler_relay_compiler_integration_test schema_not_in_project_sources ``` Currently panics - test documents the bug. Pull Request resolved: facebook#5135 Differential Revision: D90526264 Pulled By: captbaritone
e9c9aa8 to
0b113a3
Compare
Contributor
|
@captbaritone has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90526264. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema_not_in_project_sourcesthat reproduces a panic when using multi-project configThe Issue
When using a relay config with multiple projects where the schema file is located outside of all project source directories, the compiler panics at
build_schema.rs:115with "no entry found for key".Reproduction
https://github.com/budde377/relay-multirepo-reproduction
Test plan
Currently panics - test documents the bug.