Multi-project setup panics

[budde377]

I am trying to setup my yarn workspace using multi-project config files, but the compiler panics.

Minimal reproduction: https://github.com/budde377/relay-multirepo-reproduction

Ways to reproduce:

1. Checkout code and install.
2. Run yarn relay

Error:

➜  relay-multirepo-reproduction git:(main) RUST_BACKTRACE=1 yarn relay
[INFO] Querying files to compile...
[INFO] [a] compiling...

thread '<unnamed>' panicked at crates/relay-compiler/src/build_project/build_schema.rs:115:27:
no entry found for key
[INFO] [b] compiling...
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: relay_compiler::build_project::build_schema::get_schema_sources
   4: relay_compiler::build_project::build_schema::build_schema
   5: relay_compiler::build_project::build_project
   6: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume
   7: rayon::iter::plumbing::Folder::consume_iter
   8: rayon::iter::plumbing::bridge_producer_consumer::helper
   9: rayon_core::join::join_context::{{closure}}
  10: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  11: rayon_core::registry::WorkerThread::wait_until_cold
  12: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

thread '<unnamed>' panicked at crates/relay-compiler/src/build_project/build_schema.rs:115:27:
no entry found for key
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: relay_compiler::build_project::build_schema::get_schema_sources
   4: relay_compiler::build_project::build_schema::build_schema
   5: relay_compiler::build_project::build_project
   6: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume
   7: rayon::iter::plumbing::Folder::consume_iter
   8: rayon::iter::plumbing::bridge_producer_consumer::helper
   9: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  10: rayon_core::registry::WorkerThread::wait_until_cold
  11: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Config file:

{
  "projects": {
    "a": {
      "schema": "./schema.graphql",
      "language": "typescript"
    },
    "b": {
      "schema": "./schema.graphql",
      "language": "typescript"
    }
  },
  "sources": {
    "a": "a",
    "b": "b"
  }
}

[captbaritone]

I suspect this is downstream of Relay expecting the schema to be within one of the sources directories. You can try moving the schema into a source directory (or adding a new one shared by both projects). In the mean time I'll look at a regression test and a fix which gives a helpful error instead of panicking. Thanks for the report.

[captbaritone]

Integration test repro: #5135

[budde377]

Thanks for getting back to me @captbaritone. I've updated the example repo moving the schema into a third package

{
  "projects": {
    "a": {
      "schema": "./c/schema.graphql",
      "language": "typescript"
    },
    "b": {
      "schema": "./c/schema.graphql",
      "language": "typescript"
    },
    "c": {
      "schema": "./c/schema.graphql",
      "language": "typescript"
    }
  },
  "sources": {
    "a": "a",
    "b": "b",
    "c": "c"
  }
}

I am still getting panics

➜  relay-multirepo-reproduction git:(main) RUST_BACKTRACE=1 yarn relay
[INFO] Querying files to compile...
[INFO] [b] compiling...

thread '<unnamed>' panicked at crates/relay-compiler/src/build_project/build_schema.rs:115:27:
no entry found for key
[INFO] [a] compiling...
[INFO] [c] compiling...
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: relay_compiler::build_project::build_schema::get_schema_sources
   4: relay_compiler::build_project::build_schema::build_schema
   5: relay_compiler::build_project::build_project
   6: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume
   7: rayon::iter::plumbing::Folder::consume_iter
   8: rayon::iter::plumbing::bridge_producer_consumer::helper
   9: rayon_core::join::join_context::{{closure}}
  10: rayon::iter::plumbing::bridge_producer_consumer::helper
  11: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  12: rayon_core::registry::WorkerThread::wait_until_cold
  13: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

thread '<unnamed>' panicked at crates/relay-compiler/src/build_project/build_schema.rs:115:27:
no entry found for key
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: relay_compiler::build_project::build_schema::get_schema_sources
   4: relay_compiler::build_project::build_schema::build_schema
   5: relay_compiler::build_project::build_project
   6: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume
   7: rayon::iter::plumbing::Folder::consume_iter
   8: rayon::iter::plumbing::bridge_producer_consumer::helper
   9: rayon_core::join::join_context::{{closure}}
  10: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  11: rayon_core::registry::WorkerThread::wait_until_cold
  12: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

thread '<unnamed>' panicked at crates/relay-compiler/src/build_project/build_schema.rs:115:27:
no entry found for key
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::option::expect_failed
   3: relay_compiler::build_project::build_schema::get_schema_sources
   4: relay_compiler::build_project::build_schema::build_schema
   5: relay_compiler::build_project::build_project
   6: <rayon::iter::map::MapFolder<C,F> as rayon::iter::plumbing::Folder<T>>::consume
   7: rayon::iter::plumbing::Folder::consume_iter
   8: rayon::iter::plumbing::bridge_producer_consumer::helper
   9: <rayon_core::job::StackJob<L,F,R> as rayon_core::job::Job>::execute
  10: rayon_core::registry::WorkerThread::wait_until_cold
  11: rayon_core::registry::ThreadBuilder::run
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Please let me know if I misunderstood your suggestion.

[captbaritone]

Ah. The issue is that we fail to normalize paths correctly. Remove the ./ before your schema paths and see if that helps (fix incoming)

[budde377]

That did the trick! Thank you again.

[captbaritone]

Fix landed here: a4b0ae7

In the next version of Relay these relative paths will work correctly.