[Flight] Improve owner and component stacks when aborting #34755
+601
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unstubbable
changed the title
github-actions
bot
added
the
React Core Team
unstubbable
changed the title
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
2 times, most recently
from
5e89b83 to
b174161
Compare
sebmarkbage
reviewed
Oct 6, 2025
| // Promise that was aborted. This won't necessarily have I/O associated with it but | ||
| // it's a point of interest. | ||
| // However, if the Promise and IO node have the same owner, it likely means a sync component | ||
| // created both the Promise and initiated the I/O. Prefer the IO node for more specific info. |
There was a problem hiding this comment.
This part doesn't make sense to me. Why would this be an indicator that it's better?
There was a problem hiding this comment.
Whoops, that's a leftover I forgot to remove. We actually don't need this condition.
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
from
b174161 to
f5a07a5
Compare
when scheduling prerendering and aborting in successive tasks using setImmediate ✕ includes deeper location for hanging promises ✓ includes deeper location for hanging promises in ignore-listed components ! includes deeper location for unresolved I/O (this one is flaky!) when scheduling prerendering and aborting in successive tasks using setTimeout ✓ includes deeper location for hanging promises ✕ includes deeper location for hanging promises in ignore-listed components ✕ includes deeper location for unresolved I/O
unstubbable
force-pushed
the
improve-aborted-promise-stacks
branch
from
d30af01 to
3e5782f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #34638, covering not only hanging promises, but also unresolved I/O.