[Flight] Improve aborted hanging promise stacks #34638
Draft
+202
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: dce1f6c...f1b6be1 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
unstubbable
force-pushed
the
hanging-promise-test
branch
from
4beef64 to
edff0c1
Compare
unstubbable
changed the title
unstubbable
force-pushed
the
hanging-promise-test
branch
from
edff0c1 to
7e9699b
Compare
unstubbable
changed the title
unstubbable
force-pushed
the
hanging-promise-test
branch
from
8f746a7 to
4c3a1fa
Compare
unstubbable
force-pushed
the
hanging-promise-test
branch
from
4c3a1fa to
f1b6be1
Compare
sebmarkbage
reviewed
Sep 29, 2025
| // it's a point of interest. | ||
|
|
||
| // If the awaited node was an await in user space, that will typically have a more | ||
| // useful stack. Try to find one, before falling back to using the promise node. |
There was a problem hiding this comment.
This is not right. If that was the case, we could always just use the await, but we don't. We provide both (and often favor the I/O one for presentation).
The question is, why isn't the "await" already in the data as the await node and why isn't the frontend (probably Fizz in this case) picking that one over the I/O if the I/O is missing stack?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.