[compiler] Implement support for hoisted and recursive functions #30922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Introduces a new binding kind for functions that allows them to be hoisted. Also has the result of causing all nested function declarations to be outputted as function declarations, not as let bindings. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
reviewed
Sep 9, 2024
Comment on lines
1004
to
1017
| case InstructionKind.HoistedFunction: | ||
| CompilerError.invariant(false, { | ||
| reason: 'Unexpected HoistedFunction variable in for..in collection', | ||
| description: null, | ||
| loc: iterableItem.loc, | ||
| suggestions: null, | ||
| }); | ||
| case InstructionKind.Function: | ||
| CompilerError.invariant(false, { | ||
| reason: 'Unexpected Function variable in for..in collection', | ||
| description: null, | ||
| loc: iterableItem.loc, | ||
| suggestions: null, | ||
| }); |
There was a problem hiding this comment.
we could just collapse all these unsupported cases
josephsavona
reviewed
Sep 9, 2024
Comment on lines
1120
to
1133
| case InstructionKind.HoistedFunction: | ||
| CompilerError.invariant(false, { | ||
| reason: 'Unexpected HoistedFunction variable in for..of collection', | ||
| description: null, | ||
| loc: iterableItem.loc, | ||
| suggestions: null, | ||
| }); | ||
| case InstructionKind.Function: | ||
| CompilerError.invariant(false, { | ||
| reason: 'Unexpected Function variable in for..of collection', | ||
| description: null, | ||
| loc: iterableItem.loc, | ||
| suggestions: null, | ||
| }); |
…ctions" Summary: Introduces a new binding kind for functions that allows them to be hoisted. Also has the result of causing all nested function declarations to be outputted as function declarations, not as let bindings. [ghstack-poisoned]
…ctions" Summary: Introduces a new binding kind for functions that allows them to be hoisted. Also has the result of causing all nested function declarations to be outputted as function declarations, not as let bindings. [ghstack-poisoned]
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Summary: Introduces a new binding kind for functions that allows them to be hoisted. Also has the result of causing all nested function declarations to be outputted as function declarations, not as let bindings. ghstack-source-id: fa40d49 Pull Request resolved: #30922 DiffTrain build for [d7167c3](d7167c3)
eps1lon
pushed a commit
to vercel/next.js
that referenced
this pull request
Sep 18, 2024
**breaking change for canary users: Bumps peer dependency of React from `19.0.0-rc-206df66e-20240912` to `19.0.0-rc-a99d8e8d-20240916`** [diff facebook/react@206df66e...a99d8e8d](facebook/react@206df66...a99d8e8) <details> <summary>React upstream changes</summary> - facebook/react#30977 - facebook/react#30971 - facebook/react#30922 - facebook/react#30917 - facebook/react#30902 - facebook/react#30912 - facebook/react#30970 - facebook/react#30969 - facebook/react#30967 - facebook/react#30966 - facebook/react#30960 - facebook/react#30968 - facebook/react#30961 - facebook/react#28255 - facebook/react#30957 - facebook/react#30958 - facebook/react#30959 - facebook/react#30951 - facebook/react#30954 - facebook/react#30920 - facebook/react#30942 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Introduces a new binding kind for functions that allows them to be hoisted. Also has the result of causing all nested function declarations to be outputted as function declarations, not as let bindings.