Skip to content

Conversation

@sebmarkbage
Copy link
Collaborator

I don't know why this is here since all these callsites are within the CommitWork/CommitEffects helpers.

This should help with inlining.

I don't know why this is here since all these callsites are within the
CommitWork/CommitEffects helpers.

Should help inline this.
@vercel
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:06pm

@react-sizebot
Copy link

react-sizebot commented Sep 16, 2024

Comparing: 26855e4...ca51f75

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.30 kB 509.35 kB = 91.10 kB 91.10 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.81 kB 91.81 kB
facebook-www/ReactDOM-prod.classic.js = 604.86 kB 604.85 kB = 106.86 kB 106.86 kB
facebook-www/ReactDOM-prod.modern.js = 581.12 kB 581.13 kB = 103.01 kB 103.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a17fd6f

@sebmarkbage
Copy link
Collaborator Author

@acdlite says ok

@sebmarkbage sebmarkbage merged commit 8152e5c into facebook:main Sep 16, 2024
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
I don't know why this is here since all these callsites are within the
CommitWork/CommitEffects helpers.

This should help with inlining.

DiffTrain build for commit 8152e5c.
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
I don't know why this is here since all these callsites are within the
CommitWork/CommitEffects helpers.

This should help with inlining.

DiffTrain build for [8152e5c](8152e5c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants