Add different string ref warning when owner and self are different #17864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ff93a34:
|
Details of bundled changes.Comparing: 29b4d07...ff93a34 react
react-test-renderer
react-native-renderer
react-art
react-dom
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% React: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 29b4d07...ff93a34 react
react-native-renderer
react-reconciler
react-dom
react-art
react-test-renderer
ReactDOM: size: 0.0%, gzip: -0.0% React: size: 0.0%, gzip: -0.0% Size changes (stable) |
lunaruan
force-pushed
the
string_ref_warn
branch
from
8da85b2
to
3bd634a
Compare
sebmarkbage
reviewed
Jan 18, 2020
| mixedRef, | ||
| getStackByFiberInDevAndProd(returnFiber), | ||
| ); | ||
| if ( |
There was a problem hiding this comment.
The warnAboutStringRefs flag just says to turn on a warning for all string refs, regardless if it's in strict mode or not. That's a very aggressive flag. If you're getting warnings for everything then it's not much better to get a slightly different message (unless filtering but nobody does that).
I think we'll want to add this warning much more aggressively. I.e. not behind a flag at all and also fire it outside strict mode.
| element._self && | ||
| element._owner.stateNode !== element._self | ||
| ) { | ||
| console.error( |
There was a problem hiding this comment.
The reason we put the other warning in this file is because it's the only way to know if you're in StrictMode or not.
However, it's a sub-optimal place to put it because the error stack isn't as good. It doesn't point out the exact callsite. Since we don't need to check for StrictMode and can just always warn, you can instead put this in React.jsx and React.createElement so that we get better error stacks.
You can disable the warning here for that case to avoid the duplicate.
| element._owner.stateNode !== element._self | ||
| ) { | ||
| console.error( | ||
| 'Owner and self do not match for the string ref "%s". Support for ' + |
There was a problem hiding this comment.
This doesn't really tell the user anything. They don't know what owner and self not matching means. How about:
Support for string refs will be removed in a future major release. This case cannot be automatically converted to an arrow function. We ask you to manually fix this case by using useRef() or createRef() instead. Learn more about using refs safely here: https://fb.me/react-strict-mode-string-ref%s
lunaruan
force-pushed
the
string_ref_warn
branch
from
3bd634a
to
6cb196b
Compare
sebmarkbage
reviewed
Jan 21, 2020
packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.internal.js
Show resolved
Hide resolved
lunaruan
force-pushed
the
string_ref_warn
branch
2 times, most recently
from
75a0552
to
d8a2020
Compare
sebmarkbage
approved these changes
Jan 22, 2020
packages/react/src/ReactElement.js
Outdated
| 'Component "%s" contains the string ref "%s". ' + | ||
| 'Support for string refs will be removed in a future major release. ' + | ||
| 'This case cannot be automatically converted to an arrow function. ' + | ||
| 'We as you to manually fix this case by using useRef() or createRef() instead. ' + |
lunaruan
force-pushed
the
string_ref_warn
branch
from
d8a2020
to
debdb1b
Compare
lunaruan
force-pushed
the
string_ref_warn
branch
from
debdb1b
to
ff93a34
Compare
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When owner and self are different for string refs, we can't easily convert them to callback refs. This PR adds a warning for string refs for everyone when owner and self are different to tell users to manually update these refs.