StrictMode should call sCU twice in DEV #17942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
threepointone
approved these changes
Jan 30, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9682e5b:
|
It's odd, huh? I guess the idea is that you can pick multiple reviewers, then one fo them could self-assign. I'm trying to use both fields to see if it helps get PRs faster :) |
Merged
threepointone
pushed a commit
to reactjs/react.dev
that referenced
this pull request
Mar 4, 2020
…Mode This landed in 16.13 via facebook/react#17942
threepointone
pushed a commit
to reactjs/react.dev
that referenced
this pull request
Mar 4, 2020
…Mode (#2810) This landed in 16.13 via facebook/react#17942
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight before. Even our docs suggested that sCU should be called twice:
https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects