[Danger] Look at adding this repo as an upstream base #12229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is failure expected? |
|
Nope, and I'm a tad sad that the error wasn't picked up and presented in the message - I have passing tests for that. :( |
|
OK, so it ran with 86ee9e8 to ac644db Which feels right, which is the commit I branched off from. Not my fork's master. $ git log --oneline
ac644db6f (HEAD -> danger_remotes, orta/danger_remotes) [Danger] Add a remote for the upstream repo, and try use that for the merge base for danger
86ee9e848 (origin/master, origin/HEAD, react_dom, master) NativeMethodsMixin DEV-only methods should not warn (#12212)
41b8c65f1 Add react-is package (#12199) |
… merge base for danger
|
Let’s try it! Thanks. |
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
… merge base for danger (facebook#12229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #12220 (comment)
Uses the Danger DSL to grab the base repo and branch, adds it as a remote (and fetches) for reference master on my personal fork is at d906de7 and master for facebook/react is 1fd205a (as of creating this PR)