Add an unit test for React.Fragment with ShallowRenderer

[koba04]

I think it would be nice to add a test to verity that React.Fragment works fine with ShallowRenderer.

[gaearon]

@orta Any ideas why it chose https://github.com/facebook/react/commits/905bfcec60d4aec271d523c4076661bec2a30b60 as (from 2015) as the base commit?

I guess it's because it's the master of @koba04's fork (https://github.com/koba04/react). Shouldn't we be calculating against the target's master?

In fact, shouldn't we use the PR target branch and target fork instead of origin/master for calculating merge base?

[orta]

In fact, shouldn't we use the PR target branch and target fork instead of origin/master for calculating merge base?

Yeah, this makes sense, I guess circle is cloning their repo and using their master. Will probably need to add a git remote add fb [git link] and use that for the merge-base 👍 - will make time after tomorrow

[gaearon]

I think ideally it shouldn’t even necessarily be tied to master or a specific origin. Like what if you send a PR against another PR, even across forks.

My intuition is that instead of origin/master it should use target/target-branch where target is the fork against which the PR was sent (I assume we know it?) and target-branch is the branch against which the PR was sent. Basically the same things GitHub shows at the top of any PR.

[koba04]

Thanks! CI is passed! 🚀