feat: mark inset*, marginBlock*, marginInline*, paddingBlock* and paddingInline* props as built-in support
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecreeth
changed the title
inset*, marginBlock*, marginInline*, paddingBlock* and paddingInline* props as built-in support
|
I'm getting this coverage error: Jest: "global" coverage threshold for branches (89%) not met: 88.79%Weird... I didn't add any new functionality. |
|
We haven't been using the built in support because all logical styles aren't fully implemented in RN yet, and we had problems in the past with missing desktop support. I'll ask around and see if we can start to drop some of the polyfills |
necolas
reviewed
Oct 15, 2024
| @@ -1011,6 +1008,7 @@ exports[`properties: logical direction inset: inset vs top 1`] = ` | |||
| { | |||
| "style": { | |||
| "bottom": 100, | |||
| "insetBlockStart": 3, | |||
There was a problem hiding this comment.
This looks like a regression? Depends on whether RN ignore the logical style in favor of the physical style
There was a problem hiding this comment.
This is how RN works, so this might be expected.
necolas
reviewed
Oct 15, 2024
| @@ -1031,6 +1028,7 @@ exports[`properties: logical direction inset: insetBlock vs top 1`] = ` | |||
| { | |||
| "style": { | |||
| "bottom": 100, | |||
| "insetBlockStart": 3, | |||
|
Looks like a miss the |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This layout props have been implemented in main (default as of 0.76).
Check 46478 for more information.
Should we continue to test these props?