-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Expo SDK in example #236
Comments
I'm happy to help advance Expo CSS extraction sitaution! Overview:
Watch Mode:
Design Considerations:
|
Thanks, that explanation is very helpful. It looks like a pretty good approach. I'm happy to use it in the example app. Does postcss automatically get run during the Expo and Next build process? |
Yes, both Expo and Next.js run PostCSS automatically, so the generated CSS will be bundled automatically on builds/dev. It isn't relevant to Expo Web usage but Next.js has a known next/babel compatibility issue with App Dir so my plugin usage with Next.js is more experimental. I'll look into configuring the example app to use my plugin and send a PR! |
One thing I noticed is that it would be good if the plugin internally included the RSD package in its "include" paths array so users don't have to point to internals |
Thank you very much @ecreeth @javascripter for the quick help and excellent work! I'll work on the last piece, the extra docs, and let you know when that's ready for review |
One more thing I'd like to do is make the Expo example a proper Expo app, e.g., using whatever universal routing system they ship these days. We could even have a |
Is there still interest in providing Next.js example for RSD as well? I created a demo for Next.js 15 with RSD using postcss-react-strict-dom plugin below. Quick summary:
The output seems to be an exact match, except for the last image loading text which doesn't show in my example(I haven't examined yet). @nmn The same technique can be used to develop StyleX PostCSS Plugin as well I think. |
Update the Expo SDK
We use Expo to power the example / visual regression testing app. Keeping this up-to-date is important for the following reasons:
The current challenges
Action items
postcss-react-strict-dom
.cc @ecreeth @javascripter
The text was updated successfully, but these errors were encountered: