Remove const_cast from appendChild by fixing API signature#55784
Open
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Open
Remove const_cast from appendChild by fixing API signature#55784sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
Summary: Change appendChild to take non-const parent ShadowNode pointer since the method mutates the parent by appending a child to it. This removes the const_cast in ConcreteComponentDescriptor::appendChild which was a code smell. The parent node is always unsealed during tree construction when appendChild is called, so passing a non-const pointer accurately reflects the mutation that occurs. Changelog: [Internal] [Changed] - Remove const_cast from appendChild in Fabric renderer Reviewed By: javache Differential Revision: D90763774
meta-cla
bot
added
the
CLA Signed
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 27, 2026
…55784) Summary: Change appendChild to take non-const parent ShadowNode pointer since the method mutates the parent by appending a child to it. This removes the const_cast in ConcreteComponentDescriptor::appendChild which was a code smell. The parent node is always unsealed during tree construction when appendChild is called, so passing a non-const pointer accurately reflects the mutation that occurs. Changelog: [Internal] [Changed] - Remove const_cast from appendChild in Fabric renderer Reviewed By: javache Differential Revision: D90763774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Change appendChild to take non-const parent ShadowNode pointer since the
method mutates the parent by appending a child to it. This removes the
const_cast in ConcreteComponentDescriptor::appendChild which was a code
smell.
The parent node is always unsealed during tree construction when
appendChild is called, so passing a non-const pointer accurately
reflects the mutation that occurs.
Changelog:
[Internal] [Changed] - Remove const_cast from appendChild in Fabric renderer
Reviewed By: javache
Differential Revision: D90763774