Fix const-correctness for ShadowNodeFamily#55783
Closed
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Closed
Fix const-correctness for ShadowNodeFamily#55783sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC wants to merge 2 commits intofacebook:mainfrom
Conversation
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
ae7d39a to
f358c3b
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
f358c3b to
49bcab9
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 26, 2026
Summary: Pull Request resolved: facebook#55783 Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
Summary: D93806249 removed `getUIImplementation()` from `UIManagerModule` as part of the Legacy Architecture cleanup. However, third-party libraries like `react-native-safe-area-context` still reference this method, causing build failures in the e2e template app tests. This restores the method as a deprecated stub that returns `null`, maintaining backwards compatibility while keeping the Legacy Architecture cleanup intact. Libraries that depend on this method will need to handle the `null` return value or update to newer versions that don't use this deprecated API. Changelog: [Android][Fixed] - Restore getUIImplementation() stub for backwards compatibility with third-party libraries Differential Revision: D94654682
Summary: Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
49bcab9 to
74c62d0
Compare
sammy-SC
added a commit
to sammy-SC/react-native
that referenced
this pull request
Feb 27, 2026
Summary: Changelog: [Internal] remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords. Reviewed By: christophpurrer Differential Revision: D90763777
|
This pull request has been merged in 178c30d. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in 178c30d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.
Reviewed By: christophpurrer
Differential Revision: D90763777