Skip to content

Fix const-correctness for ShadowNodeFamily#55783

Closed
sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC:export-D90763777
Closed

Fix const-correctness for ShadowNodeFamily#55783
sammy-SC wants to merge 2 commits intofacebook:mainfrom
sammy-SC:export-D90763777

Conversation

@sammy-SC
Copy link
Contributor

Summary:
Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777

@meta-codesync
Copy link

meta-codesync bot commented Feb 26, 2026

@sammy-SC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90763777.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2026
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 26, 2026
Summary:

Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 26, 2026
Summary:

Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 26, 2026
Summary:
Pull Request resolved: facebook#55783

Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777
Summary:
D93806249 removed `getUIImplementation()` from `UIManagerModule` as part of the
Legacy Architecture cleanup. However, third-party libraries like
`react-native-safe-area-context` still reference this method, causing build
failures in the e2e template app tests.

This restores the method as a deprecated stub that returns `null`, maintaining
backwards compatibility while keeping the Legacy Architecture cleanup intact.
Libraries that depend on this method will need to handle the `null` return value
or update to newer versions that don't use this deprecated API.

Changelog: [Android][Fixed] - Restore getUIImplementation() stub for backwards compatibility with third-party libraries

Differential Revision: D94654682
Summary:

Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777
sammy-SC added a commit to sammy-SC/react-native that referenced this pull request Feb 27, 2026
Summary:

Changelog: [Internal]

remove unnecessary const from ShadowNodeFamily. This allows us to get rid of a few mutable keywords.

Reviewed By: christophpurrer

Differential Revision: D90763777
@meta-codesync meta-codesync bot closed this in 178c30d Feb 27, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 27, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 27, 2026

This pull request has been merged in 178c30d.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @sammy-SC in 178c30d

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants