Skip to content

Fix VirtualizeSectionList generic arguments #51496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

coado
Copy link
Contributor

@coado coado commented May 21, 2025

Summary:
Fixes problem with generics passed to VirtualizedSectionList in generated types. The flow-api-translator creates a re-declaration for export default variables which shadows generics.

Changelog:
[Internal]

Differential Revision: D75141051

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner labels May 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75141051

@coado coado force-pushed the export-D75141051 branch from b1fb5eb to 490264a Compare May 22, 2025 07:36
coado added a commit to coado/react-native that referenced this pull request May 22, 2025
Summary:

Fixes problem with generics passed to `VirtualizedSectionList` in generated types. The `flow-api-translator` creates a re-declaration for `export default` variables which shadows generics.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D75141051
Summary:
Pull Request resolved: facebook#51496

Fixes problem with generics passed to `VirtualizedSectionList` in generated types. The `flow-api-translator` creates a re-declaration for `export default` variables which shadows generics.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D75141051
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75141051

@coado coado force-pushed the export-D75141051 branch from 490264a to 6418898 Compare May 22, 2025 07:40
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 44b0f55.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @coado in 44b0f55

When will my fix make it into a release? | How to file a pick request?

react-native-bot pushed a commit that referenced this pull request May 23, 2025
Summary:
Pull Request resolved: #51496

Fixes problem with generics passed to `VirtualizedSectionList` in generated types. The `flow-api-translator` creates a re-declaration for `export default` variables which shadows generics.

Changelog:
[Internal]

Reviewed By: huntie

Differential Revision: D75141051

fbshipit-source-id: 260ef066038320eee3ffa93692f77f1eff5c9205
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @coado in 869c03e

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook p: Software Mansion Partner: Software Mansion Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants