Skip to content

Commit 44b0f55

Browse files
coadofacebook-github-bot
authored andcommitted
Fix VirtualizeSectionList generic arguments (#51496)
Summary: Pull Request resolved: #51496 Fixes problem with generics passed to `VirtualizedSectionList` in generated types. The `flow-api-translator` creates a re-declaration for `export default` variables which shadows generics. Changelog: [Internal] Reviewed By: huntie Differential Revision: D75141051 fbshipit-source-id: 260ef066038320eee3ffa93692f77f1eff5c9205
1 parent f900551 commit 44b0f55

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

packages/virtualized-lists/Lists/VirtualizedSectionList.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ function ItemWithSeparator<ItemT>(
611611
);
612612
}
613613

614-
export default VirtualizedSectionList as component<
614+
const VirtualizedSectionListComponent = VirtualizedSectionList as component<
615615
ItemT,
616616
SectionT: SectionBase<ItemT, DefaultSectionT> = DefaultSectionT,
617617
>(
@@ -623,3 +623,10 @@ export default VirtualizedSectionList as component<
623623
>,
624624
...VirtualizedSectionListProps<ItemT, SectionT>
625625
);
626+
627+
export default VirtualizedSectionListComponent;
628+
629+
export type AnyVirtualizedSectionList = typeof VirtualizedSectionListComponent<
630+
any,
631+
any,
632+
>;

packages/virtualized-lists/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
import typeof FillRateHelper from './Lists/FillRateHelper';
1414
import typeof ViewabilityHelper from './Lists/ViewabilityHelper';
1515
import typeof VirtualizedList from './Lists/VirtualizedList';
16-
import typeof VirtualizedSectionList from './Lists/VirtualizedSectionList';
16+
import type {AnyVirtualizedSectionList} from './Lists/VirtualizedSectionList';
1717

1818
import {typeof VirtualizedListContextResetter} from './Lists/VirtualizedListContext';
1919
import {keyExtractor} from './Lists/VirtualizeUtils';
@@ -45,7 +45,7 @@ export default {
4545
get VirtualizedList(): VirtualizedList {
4646
return require('./Lists/VirtualizedList').default;
4747
},
48-
get VirtualizedSectionList(): VirtualizedSectionList<any, any> {
48+
get VirtualizedSectionList(): AnyVirtualizedSectionList {
4949
return require('./Lists/VirtualizedSectionList').default;
5050
},
5151
get VirtualizedListContextResetter(): VirtualizedListContextResetter {

0 commit comments

Comments
 (0)