Add assert for recycled views with parent #49937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
lenaic
force-pushed
the
export-D70922503
branch
from
b2343bc to
1dcfaa3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922503 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922503 |
lenaic
force-pushed
the
export-D70922503
branch
from
1dcfaa3 to
26268b7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922503 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Mar 10, 2025
Summary: Pull Request resolved: facebook#49937 Adding an assert for recycled views still attached to their parent, which would lead to an exception when the view would be added to a new parent. Changelog: [Internal] Differential Revision: D70922503
lenaic
force-pushed
the
export-D70922503
branch
2 times, most recently
from
1531f52 to
961d8ca
Compare
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Mar 11, 2025
Summary: Adding an assert for recycled views still attached to their parent, which would lead to an exception when the view would be added to a new parent. Changelog: [Internal] Reviewed By: javache Differential Revision: D70922503
Summary: Pull Request resolved: facebook#49937 Adding an assert for recycled views still attached to their parent, which would lead to an exception when the view would be added to a new parent. Changelog: [Internal] Reviewed By: javache Differential Revision: D70922503
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70922503 |
lenaic
force-pushed
the
export-D70922503
branch
from
961d8ca to
bf7d4f5
Compare
Contributor
|
This pull request has been merged in 1482dd9. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 1482dd9 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding an assert for recycled views still attached to their parent, which would lead to an exception when the view would be added to a new parent.
Changelog: [Internal]
Differential Revision: D70922503